[parted-devel] [PATCH 0/3 v2] Support for partitions on loop devices

[Jim Meyering]

Petr Uzel wrote:
> On Thu, Sep 29, 2011 at 04:42:56PM +0200, Jim Meyering wrote:
>> Petr Uzel wrote:
>> > This is the second version of patch series to improve support
>> > for partitionable loop devices in parted.
>> >
>> > Changes since v1:
>> >
>> > o Added test to exercise the feature.
>> > o Style fixes suggested by Jim.
>> >
>> [SNIP]
>
> Hi Jim, thanks a lot for the review. The level of perfectionism
> with which you review the patches and suggest improvements is amazing!

Amazingly annoying for some contributors ;-)
I'm glad you manage to put up with it.

...
>> In fact, this entire test fails on pre-linux-3.0 systems.
>> (it's failing on my Fedora 15 2.6.40.4-5.fc15.x86_64 desktop)
>> It'd be nice to make it skip rather than fail in that case, but I
>> don't mind if these proposed test-related changes are in a separate
>> patch.  That might be better regardless,...
>
> Hm, it works fine on my 2.6.37.6. What does it fail on on your system?

Hmm... it even fails on rawhide (in a VM)
with this kernel:

  3.1.0-0.rc8.git0.0.fc17.x86_64

I.e., running this:

    sudo make check -C tests TESTS=t8001-loop-blkpg.sh VERBOSE=yes

I get this in tests/t8001-loop-blkpg.sh.log:

+ lsmod
+ grep '^loop[[:space:]]'
+ modprobe loop max_part=7
+ dd if=/dev/zero of=backing_file bs=1M count=4
++ losetup -f --show backing_file
+ loopdev=/dev/loop0
+ test -z /dev/loop0
+ parted -s /dev/loop0 mklabel msdos
+ compare err /dev/null
+ diff -u err /dev/null
+ parted -s /dev/loop0 mkpart primary 1M 2M
+ compare /dev/null err
+ diff -u /dev/null err
+ udevadm settle --timeout=5
++ basename /dev/loop0p1
+ entry=loop0p1
+ grep loop0p1 /proc/partitions
+ cat /proc/partitions
major minor  #blocks  name

   7        0       4096 loop0
 252        0   10485760 vda
 252        1     512000 vda1
 252        2    8743936 vda2
 252        3    1228800 vda3
+ fail=1
+ parted -s /dev/loop0 rm 1
+ compare /dev/null err
+ diff -u /dev/null err
+ udevadm settle --timeout=5
+ grep loop0p1 /proc/partitions
+ Exit 1

Maybe we have different kernel patches?
I can't investigate now: no more time for parted today.

>> If you ACK what I've included below, I'll push these three commits.
>
> ACKed. Thanks!

Pushed.