[parted-devel] [PATCH 5/6] libparted: handle logical partitions starting immediately after the EBR

[Jim Meyering]

Phillip Susi wrote:
> _blkpg_add_partition() set the length of the extended partition
> to 2 sectors to allow LILO to be installed there, beacuse the
> linux kernel does this.  If a logical partition used that second
> sector, adding it would fail beacuse of the overlap.  Now
> _blkpg_add_partition() will limit the length to only the first
> sector if the second is used by a logical partition.

Hi Phillip,

Thanks for your patience.
I have a couple questions about this change:
  - why?  The commit log (or perhaps comments in the code) should tell
    us why this change is desirable.
  - if we make this change, won't that let parted create
    partition tables that cause older linux kernels to object?
  - if you do change the code not to require the 2-sector "size",
    please also change the name of that test script.

>  libparted/arch/linux.c                          |   10 +++++++++-
>  tests/t2310-dos-extended-2-sector-min-offset.sh |   20 ++++----------------
>  2 files changed, 13 insertions(+), 17 deletions(-)
...
> --- a/tests/t2310-dos-extended-2-sector-min-offset.sh
> +++ b/tests/t2310-dos-extended-2-sector-min-offset.sh
> @@ -1,8 +1,6 @@
>  #!/bin/sh
> -# Ensure that parted leaves at least 2 sectors between the beginning
> +# Ensure that parted allows a single sector between the beginning
...