[parted-devel] [PATCH 6/6] libparted: fix optimal IO alignment

[Phillip Susi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/16/2012 02:09 AM, Jim Meyering wrote:
> I'd be suspicious because it's smaller than 1MiB and not a power of
> 2. Have you seen opt/min values like that?

Sure, take a 4 disk raid5 with 256k stripe factor.

> I suspect that the existing code is the way it is for a good
> reason, hence my reluctance to gut it. What if some system reports
> totally bogus min. or opt. values < 1MiB? As it is now, parted will
> ignore them.  But with your patch, it would use them and leave the
> user with poorly-aligned partitions.

Then that's a bug in the kernel.  Parted shouldn't ignore the kennel
on the off chance that some day somehow for someone it will have a bug.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iQEcBAEBAgAGBQJQziH8AAoJEJrBOlT6nu75NTgIAK7ElOn+xM7INVBWccKT6DsL
QlmJ+MzdDv+d0om4j/0bbywijAx8OIO70hVpczUeCph5dhh+jdBG+J/zc/uG7e7U
VS5jMwkJFWP8GUfV+w1+CNHg28QbXEOxo+p+tsEb/JCfKaqixyVma96lMiRXg3Ac
b0/sI8hLS0oJ9bKPggz36+qZx6AkSo26JFePfGCBRXPa4Bhk4Ka70rsHr+kd9tiD
o4wH5iznsbUwL2nBUtJTaqYZCU88qR6/+gp/kgLf7hKRLal7HSFeH+9vC8BvPnjL
5DKD7MGX3r7uLMYdRlmmeJhZm/SM4yYK5y4hpj94rNuB3ye/QnQ+x47mvCugUbc=
=W8hE
-----END PGP SIGNATURE-----