[parted-devel] PedDisk persistence

[Phillip Susi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I noticed one of the error checks in gpt.c can be ignored, and saves a
static local variable to suppress future reports of the error,
assuming that if you ignored it once, you probably don't want to be
bothered with it repeatedly.  This seems to be wrong, since ignoring
the error on one drive, should not cause the same error to be ignored
if you select a different drive.  It seemed this flag should be stored
in the disk data so it could be remembered on a per disk basis, but it
appears that parted creates and destroys the PedDisk with each and
every command.

Is this not wrong?  Shouldn't it create the PedDisk data, and thus,
detect and load the partition table when selecting the disk, and let
it persist between commands, until selecting another disk with the
unit command?  As it stands, it re-reads the partition table with
every single command, which seems a waste.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iQEcBAEBAgAGBQJQ4R2KAAoJEJrBOlT6nu75jdEIAJC+aSATN+H+mNK0vBVlwBXo
rVoJftMjtl6qQhbaimVoJrQ9aUtganGcc1CLf1RxxMNwtK9BUlfcNj8IHVPuK8JW
aivKeFM0SrjHDhiLPcPLW8NazhX4IEH5/fOmXOVXUP7qmMuigNurwgWyyMAa8iRU
XDJhMP9KiA43fLpjgXuWOGAkpHMGbGl/VSasPL9zr/ON6iTE4C88jNV1IGrwAjVo
52y14+8q4KvPJj9FoMBIhvkusJZPT08qdhWkFYoB+SBGfWvOf1pY692SM1k9ihAA
xYkl3FalUQg2Ef0I48BtxVYnM5Bi/XBMXi+K5P+yja+RfuN3EeVjW5CewBiTMSw=
=Vooa
-----END PGP SIGNATURE-----