[parted-devel] [PATCH 2/4] libparted: remove extraneous blkpg add partition ped exception

[Phillip Susi]

On 01/11/2012 01:37 PM, Jim Meyering wrote:
> Phillip Susi wrote:
>> _blkpg_add_partition was throwing an exception if it failed to add the new
>> partition, in addition to _disk_sync_part_table throwing one, and then
>> bailing out.  Instead of bailing out, just log the error for reporting
>> later and continue.
> 
> Thanks for the patch.
> Would you please at least outline a test case for this?

My initial thought was that it should never happen, so there can't be a test for it, but it seems that this change has actually broken t2310-dos-extended-2-sector-min-offset.sh.  It seems that this test was not testing a behavior of parted, but rather testing what I consider to be a bug in the linux kernel.  The add was failing because BLKPG_ADD_PARTITION was being rejected by the kernel for not leaving room for LILO, and this test was verifying that this behavior.  I don't think the kernel should be failing that request, and the parted test suite should not be testing for it.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 554 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/parted-devel/attachments/20120111/60fa39b3/attachment.pgp>