[parted-devel] [PATCH parted] gpt: Fix endianness issue when using pth->FirstUsableLBA.

[Richard W.M. Jones]

On Sat, Jun 09, 2012 at 05:39:46PM +0200, Jim Meyering wrote:
> Richard W.M. Jones wrote:
> > Full explanation is here:
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=829960#c6
> 
> Hi Rich,
> 
> Thanks a lot for the fix.
> I've amended your commit to add a little more of a log
> and to include a NEWS update mentioning the bug fix.
> 
> Then I added a test to give us coverage of the affected function,
> since no other test actually used that code.
> 
> Since I've amended your commit, I'll wait for an ACK from you
> before pushing it.

I took your commit, applied it to parted.git on my ppc64 box, built it
and ran the tests.  It passes the test that you added:

  PASS: t9021-maxima.sh

(and indeed all the other tests).  Therefore, ACK.

 - - -

Isn't there a tool which can detect endian violations by annotating
structs -- I seem to remember the tool that the kernel devs use
("sparse"?) can do it.

Thanks,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org