[parted-devel] [PATCH 2/2] tests: add t0301-overwrite-gpt-pmbr.sh

Jim Meyering jim at meyering.net
Mon Mar 26 19:20:01 UTC 2012


Brian C. Lane wrote:
> On Sat, Mar 24, 2012 at 10:07:49AM +0100, Jim Meyering wrote:
>> Brian C. Lane wrote:
>> > From: "Brian C. Lane" <bcl at redhat.com>
>> >
>> > Make sure parted checks the PMBR before the GPT partition table.
>> >
>> > * NEWS: Update with new GPT behavior
>> > * tests/Makefile.am: Add new test
>> > * tests/overwrite-gpt-pmbr.sh: new test
>> > ---
>> ...
>> > diff --git a/tests/t0301-overwrite-gpt-pmbr.sh
>> > b/tests/t0301-overwrite-gpt-pmbr.sh
>> ...
>> > +PARTED_SECTOR_SIZE=4096
>> > +export PARTED_SECTOR_SIZE
>>
>> I suppose the above two lines were just for testing?
>> Their presence would serve solely to disable tests with a
>> smaller simulated sector size.  I've removed them.
>
> That was carried over from t0300 test which I used as a template for
> this. You may want to remove it there as well.

Thanks for letting me know.
That must have been a debugging artifact from *me*.
I've removed those, too.

...
>> I've also adjusted the NEWS entry.
>> I'll wait for your ACK before pushing this.
>
> Looks good, thanks.

Both will be pushed shortly.



More information about the parted-devel mailing list