[parted-devel] [PATCH 06/11] libparted: respect optimal IO alignment

[Brian C. Lane]

On Mon, Jan 07, 2013 at 05:54:37PM +0100, Jim Meyering wrote:
> Phillip Susi wrote:
> > If the optimal IO size provided by the kernel was less than 1 MiB
> > or not an even power of two, parted ignored it and used 1 MiB
> > instead.  Values less than 1 MiB or not an even power of two are
> > common with raid arrays, so respect the kernel supplied value.
> > Regular disks will still use 1 MiB since the kernel returns a
> > value of zero.
> 
> Hi Phillip,
> 
> I would like to continue using the existing guards or similar
> when operating on regular disks.  Can you adjust this change to
> remove the guards only when the device is a raid array?

Is that really needed? His description is incorrect. It only uses 1MiB
if the given io size is evenly divisible into 1MiB. If the size is an
odd one it will use that instead.

I think we need specific error cases before we change this at all.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/parted-devel/attachments/20130107/c592640b/attachment.pgp>