[parted-devel] [PATCH] libparted: Fixed bug in initializing and re-reading partition table of FBA devices

Nageswara R Sastry rnsastry at linux.vnet.ibm.com
Thu Oct 31 10:16:09 UTC 2013


On 10/30/2013 6:59 PM, Phillip Susi wrote:
>> So, need to validate calling 'dasd_read()' from 'dasd_alloc()' is
>> the correct thing or not.
> 
> I don't think you actually want to read the disk, just have the same
> code to insert the implicit partition in dasd_alloc() that dasd_read()
> has.

dasd_read functionality having 280 lines of code out of which 170 lines
of code for FBA kind of disks.

The dasd_read's FBA code can not be copied so easily, because it takes
care of similar disks and many other conditions.
I feel better to call dasd_read from dasd_alloc in the case of FBA disk.

Sending second version of the patch.

Regards
R.Nageswara Sastry




More information about the parted-devel mailing list