[parted-devel] [PATCH] tests: Use force for xfs in t1700 and a larger file

Brian C. Lane bcl at redhat.com
Thu Apr 17 19:10:47 UTC 2014


On Tue, Apr 15, 2014 at 03:03:07PM -0700, Brian C. Lane wrote:
> Also use sparse files that are (with 512B blocks) 128M so that they are
> large enough for all the filesystems.
> 
> * tests/t1700-probe-fs.sh: Make changes.
> ---
>  tests/t1700-probe-fs.sh | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/t1700-probe-fs.sh b/tests/t1700-probe-fs.sh
> index 0418e73..08ec7d9 100755
> --- a/tests/t1700-probe-fs.sh
> +++ b/tests/t1700-probe-fs.sh
> @@ -21,17 +21,19 @@ require_512_byte_sector_size_
>  
>  dev=loop-file
>  ss=$sector_size_
> +n_sectors=$((257*1024))
>  
>  for type in ext2 ext3 ext4 btrfs xfs nilfs2; do
>  
>    ( mkfs.$type -V ) >/dev/null 2>&1 \
>        || { warn_ "$ME: no $type support"; continue; }
>  
> -  case $type in ext*) n_sectors=8000 force=-F;;
> -      *) n_sectors=$((257*1024)) force=;; esac
> +  case $type in ext*) force=-F;;
> +      xfs) force=-f;;
> +      *) force=;; esac
>  
>    # create an $type file system
> -  dd if=/dev/zero of=$dev bs=$ss count=$n_sectors >/dev/null || fail=1
> +  dd if=/dev/null of=$dev bs=$ss count=$n_sectors >/dev/null || fail=1

That was supposed to be seek, not count.

>    mkfs.$type $force $dev || { warn_ $ME: mkfs.$type failed; fail=1; continue; }
>  
>    # probe the $type file system
> @@ -43,7 +45,7 @@ done
>  # Some features should indicate ext4 by themselves.
>  for feature in uninit_bg flex_bg; do
>    # create an ext3 file system
> -  dd if=/dev/zero of=$dev bs=1024 count=4096 >/dev/null || fail=1
> +  dd if=/dev/null of=$dev bs=1024 count=4096 >/dev/null || fail=1

That was supposed to be seek, not count.

I'll get those fixed up.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)



More information about the parted-devel mailing list