[parted-devel] [PATCH 1/3] tests: Make t4100 xfs filesystem larger and sparse

[Jim Meyering]

On Tue, May 27, 2014 at 11:44 AM, Brian C. Lane <bcl at redhat.com> wrote:
> On Sun, May 25, 2014 at 08:20:29PM -0700, Jim Meyering wrote:
>> On Sun, May 25, 2014 at 7:35 PM, Jim Meyering <jim at meyering.net> wrote:
>> > On Sun, May 25, 2014 at 3:32 PM, Phillip Susi <psusi at ubuntu.com> wrote:
>> >> -----BEGIN PGP SIGNED MESSAGE-----
>> >> Hash: SHA512
>> >>
>> >> On 04/16/2014 10:54 PM, Brian C. Lane wrote:
>> >>> Newer versions of mkfs.xfs appear to be using more blocks for the
>> >>> journal, causing t4100-* tests to fail. Make the image larger.
>> >>>
>> >>> * tests/t4100-dvh-partition-limits.sh: Make the xfs image larger *
>> >>> tests/t4100-msdos-partition-limits.sh: Make the xfs image larger
>> >>
>> >> These three look good to me.
>> >
>> > Likewise.  Thanks.  I'd just noticed those two failures.
>>
>> Actually, I needed the additional changes (see attached) to make those two
>> tests pass using xfsprogs-3.1.1-7.el6.x86_64. Feel free to include in yours,
>> or I'll push separately.
>
> Hrm. So you're saying you *have* to create the file with dd first with
> 3.1.1-7? Seem like that should be a bug with xfsprogs instead.

No need to leave the file-creating dd with xfs.
Your patch looks perfect.  Thanks!