[parted-devel] [PATCH 0/3] Prevent crash resizing FAT16 file systems

Mike Fleetwood mike.fleetwood at googlemail.com
Sun Oct 5 10:34:53 UTC 2014


On 4 October 2014 17:37, Curtis Gedak <gedakc at gmail.com> wrote:
> One question.  In patch 3/3, a line with "skip_test_" was changed to
> "skip_".  Note the missing "test_".  Was this intentional?

Hi Curtis,

Thank you for testing the patchset.

Yes changing skip_test_ to skip_ is intentional.  skip_test_ was renamed
to skip_ by commit [1], including in the test script t3000-resize-fs.sh
before it was removed [2].  Later, when t3000-resize-fs.sh was re-added
[3], it incorrectly use the old skip_test_ name.

[1] tests: global subst: s/skip_test_/skip_/
http://git.savannah.gnu.org/cgit/parted.git/commit/?id=ee477386f0355fc5640277a466c379b5d30fdaf3

[2] tests: remove tests that are too FS-centric
http://git.savannah.gnu.org/cgit/parted.git/commit/?id=8f0d7ee20660de806ed0b1308938f80db22e21a5

[3] tests: test FAT and HFS file system resizing
http://git.savannah.gnu.org/cgit/parted.git/commit/?id=d9c1e1a5686943db044e6f24cae7d09a5a9e095c

Thanks,
Mike



More information about the parted-devel mailing list