[parted-devel] [PATCH] parted: Display details of partition alignment failure (#726856)

[Brian C. Lane]

On Fri, Nov 13, 2015 at 09:40:42PM -0500, Phillip Susi wrote:
> On 11/13/2015 11:49 AM, Brian C. Lane wrote:
> > As a general rule, yes. But we've already got the exception
> > handling there, I'm just trying to add more detail to it.
> 
> Yea, I know it is already there, but that doesn't mean it shouldn't be
> moved.  Just because it is wrong now doesn't mean we shouldn't fix it ;)
> 
> To put it another way, I think what you have done is only a half
> measure when the proper fix is really to move the throw down instead
> of floating a string up.  If you are going to fix it, you may as well
> fix it right.

I took another look at this, and still disagree. do_mkpart throws
exceptions in a couple of places based on results from the attempt to
make the partition. There is also another use of partition_align_check
in do_align_check where it doesn't throw an exception. Moving these
exceptions down into a function doesn't make sense.


-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)