[parted-devel] [PATCH 9/9] libparted: device mapper uses 512b sectors

[Phillip Susi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/6/2015 12:50 PM, Brian C. Lane wrote:
> On Fri, Feb 06, 2015 at 11:33:21AM -0500, Phillip Susi wrote:
>> On 2/6/2015 11:24 AM, Brian C. Lane wrote:
>>> We tell device-mapper the size of the disk and the partitions, 
>>> right now we are using native disk sector units for this. We
>>> need to make sure we use 512b units when talking to
>>> device-mapper.
>> 
>> Yes, but the "native disk sector units" are always 512 bytes
>> since that is what devmapper tells us it is.  We have no idea
>> that there is a 4k sector disk underneath devmapper.
> 
> That's not true. Take a look at the test, it demonstrates the
> problem.

It is at least true under normal circumstances... iirc though, the
test harness uses PED_SECTOR_SIZE to force parted to ignore the size
the disk reports and pretend it has a larger sector size.  Is that
what is going on here?  If so then then problem is only with the test
harness and I'm not entirely sure using that override that way is
really supported.  In other words, this kind of feels like a "don't do
that" bug.  On the other hand, I suppose it wouldn't *hurt* to fix it.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)

iQEcBAEBAgAGBQJU1RICAAoJENRVrw2cjl5RheIH/iEu4lhFO5S+gHILhOPjQ2yL
nQKNoBUA8G1it6JZAH9Hk7+lXbWjk1Eh0tCQZ/4uQh0r4NbeYbQRbIt/6LpT6w2f
//bE93IhC4abZoce8xz1ENI5tQAW+jc5im3mqfiq+mQ1jNSthDJVNUUjN91mV6dW
fPxalrBCMjdMeEZ9Qcu75kpCVGxQwdYMSxFGIFZV5W6wZU5aXPkcFkzeUcjHjr6J
qNNx7ANhR7tMYZopbSeb69S4B/yT9mNlAL7wijBRUlXUqJBlyfxFuKawX+JDGYd0
rbYraoVr00V7fSltWoYC15+R4JQCc5XJTrbS5YTNgzQhv/AU1pk5odBWuWEDOqk=
=NRjF
-----END PGP SIGNATURE-----