[parted-devel] [PATCH] libparted: remove O_DIRECT cruft

Brian C. Lane bcl at redhat.com
Fri Jan 16 20:02:54 UTC 2015


On Tue, Jan 13, 2015 at 02:09:20PM -0500, Phillip Susi wrote:
> linux_read was still allocating an aligned memory buffer and
> copying from there to the caller buffer, in order to support
> O_DIRECT.  This is simply a waste of time now that we don't use
> O_DIRECT.  This change resulted in nearly 10% less cpu time spent
> attempting to rescue a lost filesystem on a scsi_debug disk.

Nice!

> 
> In addition, there was some autoconf machinery to make sure that
> the test suite was run in a directory that supports O_DIRECT.
> ---

Ack

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)



More information about the parted-devel mailing list