[parted-devel] [PATCH 1/2] tests: Make sure the extended partition length is 2 (#1135493)

Brian C. Lane bcl at redhat.com
Wed Jun 24 20:04:24 UTC 2015


On Wed, Jun 24, 2015 at 01:01:07PM -0400, Phil Susi wrote:
> On 6/23/2015 3:15 PM, Brian C. Lane wrote:
> [ $ext_len -gt 1 ] || fail=1
> 
> It looks like you just changed the test to look for 1 sector, which should
> fail always.  Did you run it?

Greater than 1.

> 
> It should be:
> 
> exp_len=$((ss / 512))
> if [ $ss -eq 1 ] ;
>     $ss = 2
> fi
> [ $ext_len -eq $exp_len ] || fail=1

We don't really need to check for the specific length, just make sure it
is always at least 2.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)



More information about the parted-devel mailing list