[parted-devel] [PATCH] parted: Display details of partition alignment failure (#726856)

Brian C. Lane bcl at redhat.com
Mon Nov 9 23:14:05 UTC 2015


On Sat, Nov 07, 2015 at 04:40:51PM -0500, Phillip Susi wrote:
> On 10/28/2015 03:21 PM, Brian C. Lane wrote:
> > When alignment for a new partition fails it isn't always obvious 
> > why it failed. This adds printing the reason for the failure, in 
> > the form of:
> 
> Instead of having partition_align_check return a string for the caller
> to add to its exception, why not push the exception throwing down into
> partition_align_check itself?
> 
> 

Because it seems less messy. There's a pile of exception handling
happening in do_mkpart already. Pushing it down would make it less
obvious.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)



More information about the parted-devel mailing list