[parted-devel] [PATCH] parted: Display details of partition alignment failure (#726856)

Brian C. Lane bcl at redhat.com
Fri Nov 13 16:49:42 UTC 2015


On Wed, Nov 11, 2015 at 08:54:08PM -0500, Phillip Susi wrote:
> On 11/09/2015 06:14 PM, Brian C. Lane wrote:
> > Because it seems less messy. There's a pile of exception handling 
> > happening in do_mkpart already. Pushing it down would make it less 
> > obvious.
> 
> I'm not sure what you mean.  The general rule for exceptions is that
> they are thrown at the site where they are detected.  If a caller
> wishes to catch it, they can, but in this case, I don't see the need
> for that, so it would be simpler to throw it at the lower level and
> the caller need not be concerned with it.

As a general rule, yes. But we've already got the exception handling
there, I'm just trying to add more detail to it.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)



More information about the parted-devel mailing list