[parted-devel] I need your advice.

[Hendrik Brueckner]

Hi Michael,

On Fri, Nov 27, 2015 at 09:19:25AM +0800, Wang (Michael) Dong wrote:
> 
> I am going to do some upgrading work in parted. Just upgrade some code.

Sounds great.

>
> I wonder I should choose a dirty version which I mean a developing
> version or the latest released version to start?

That's a good question ;-)  I know that Viktor did recently some changes
for s390.  So working on top of the latest would make sense.  However, you
never know how stable it is.   From a maintainer perspective, we have to
submit any changes to the upstream repository at some point in time.  This
would then require that any changes must work on top of the latest parted
code level.

So far about the background.  I suggest the following approach:

If possible use the latest version that includes the changes from Viktor by
pulling the latest changes on the master branch.  Then run your test script,
if your test script fails for some reason, you can fallback to the latest
parted release by checking out the v3.2 tag in the repository.

For doing your code base upgrade, I suggest that you create a personal branch
in your parted repository.  For example, to branch from the up-to-date master
branch, issue.

	git checkout -b bb/<YOUR_GIT_USER_ID>/fdasd-upgrade

whereby "fdasd-upgrade" is the name of the branch.  Later, you can push your
commits on this branch to tuxmaker (for saving and reviewing your work).

If possible commit your changes regularly on a "functional" base.  I find it
easier to have serveral smaller commits than just a few big ones.  Merging
commits is typically quite easier than splitting large commits into smaller
ones.

I hope these tipps help you.

Thanks and kind regards,
  Hendrik