[parted-devel] [PATCH] parted: Add alignment error details to align-check (#726856)

Brian C. Lane bcl at redhat.com
Tue Apr 12 19:25:00 UTC 2016


On Sun, Apr 10, 2016 at 08:43:46PM -0400, Phillip Susi wrote:
> On 02/12/2016 05:01 PM, Brian C. Lane wrote:
> > When align-check is used in interactive mode and it isn't aligned
> > print the error details. Script mode behavior is unchanged.
> > 
> > Also cleanup pointer usage and handle asprintf failure by using a
> > constant string in the error report - "unknown (malloc failure)". 
> > ---
> 
> The subject line of this patch makes it sound like it should be an
> amended version of the previous one, but looking at the diff shows
> that it is actually a subsequent change on top of the previous commit.
>  Either it should be squashed into the previous one or the change log
> entry should be more clear that it is a subsequent change that only
> adds error handling and disables the message in script mode.  I'd
> prefer the former.

Right, my plan is to squash them, I posted it as a separate patch so the
changes would be clearer.

> 
> Finally, again, please do not trim me from the Cc list.  I follow the
> RFCs and set up the headers to inform all that I wish to be Cced.
> Please respect that.

I'll try to remember.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)



More information about the parted-devel mailing list