[parted-devel] [PATCH 0/2] Prevent crash resizing FAT with very deep directories

Mike Fleetwood mike.fleetwood at googlemail.com
Sat Mar 5 10:55:11 UTC 2016


On 3 March 2016 at 19:07, Brian C. Lane <bcl at redhat.com> wrote:
> On Sun, Feb 28, 2016 at 03:36:09PM +0000, Mike Fleetwood wrote:
>> Hi,
>>
>> Here's a fix for libparted-fs-resize crashing when resizing a FAT file
>> system with a deep directory tree with names over 512 bytes long.
>> Original reporter was using GParted to check and resize a FAT file
>> system created on his Android phone.  The phone was running CyanogenMod
>> and the Filemanager app had created a very deep directory tree leading
>> to a core dump.
>>
>> Bug 762448 - Check FAT32 fs crashes GParted
>> https://bugzilla.gnome.org/show_bug.cgi?id=762448
>>
>> Thanks,
>> Mike
>
> I gave this a try, and while it looks simple enough it is still
> crashing for me when I apply it to Fedora rawhide's version of parted.

I have just tried my patches on Fedora 23 and Fedora Rawhide using the
current parted GIT master (8c6de55) and they worked.  The only none
standard thing I have is a symlink of mkfs.hfs -> mkfs.hfsplus as
t3000-resize-fs.sh currently requires mkfs.hfs.

Ran test t3000-resize-fs.sh:
1) Clean GIT master
   => Pass
2) Applied test case patch first
   => Triggers crash in fs-resize and reports failure, as expected.
3) Applied code fix
   => fs-resize succeeds, test case passes



More information about the parted-devel mailing list