[parted-devel] [PATCH] libparted: Fix starting CHS in protective MBR

[Brian C. Lane]

On Thu, Mar 10, 2016 at 02:18:52PM +0100, Petr Uzel wrote:
> The CHS address for protective partition start in protective MBR
> should be 0/0/2, according to UEFI spec (v2.6, section 5.2.1).
> 
> * libparted/labels/gpt.c (_write_pmbr): Fix starting CHS address
> 
> Reported by Steffen Winterfeldt in https://bugzilla.suse.com/969165
> 
> Signed-off-by: Petr Uzel <petr.uzel at suse.cz>
> ---
>  libparted/labels/gpt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libparted/labels/gpt.c b/libparted/labels/gpt.c
> index d69377a..6027eb3 100644
> --- a/libparted/labels/gpt.c
> +++ b/libparted/labels/gpt.c
> @@ -1139,7 +1139,7 @@ _write_pmbr (PedDevice *dev, bool pmbr_boot)
>  
>    pmbr->Signature = PED_CPU_TO_LE16 (MSDOS_MBR_SIGNATURE);
>    pmbr->PartitionRecord[0].OSType = EFI_PMBR_OSTYPE_EFI;
> -  pmbr->PartitionRecord[0].StartSector = 1;
> +  pmbr->PartitionRecord[0].StartSector = 2;
>    pmbr->PartitionRecord[0].EndHead = 0xFE;

And after re-reading the spec, shouldn't this be 0xFF?

>    pmbr->PartitionRecord[0].EndSector = 0xFF;
>    pmbr->PartitionRecord[0].EndTrack = 0xFF;
> -- 
> 1.8.4.5
> 
> 

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)