[parted-devel] [PATCH] optionally delay commit in parted until requested
Brian C. Lane
bcl at redhat.com
Thu Mar 17 18:15:49 UTC 2016
On Thu, Mar 17, 2016 at 05:20:58PM +0100, Arvin Schnell wrote:
>
> Hi,
>
> attached is a patch to allow parted via on option to keep changes
> to the partition table only in memory until explicitely requested
> to write them to disk. Other partitioning programs, e.g. fdisk,
> can operate like that and I sometimes prefer that mode.
>
> Feedback is welcome.
Please use spaces instead of tabs, and if you could submit it as a git
formatted patch that would make it easier to merge.
It looks pretty good to me, but I wonder if we should print a message
when they exit without committing to make sure the user understands
nothing was written.
A test would also be nice, something that makes a disk image, creates a
label and some partitions, then runs on it again without doing the
commit and test to make sure no changes were made.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
More information about the parted-devel
mailing list