[parted-devel] [PATCH] libparted/dasd: improve lvm/raid flag handling for DASD-CDL

Wang Dong dongdwdw at linux.vnet.ibm.com
Fri Apr 21 02:07:49 UTC 2017



On 04/21/2017 04:02 AM, Phil Susi wrote:
> On 4/17/2017 10:07 PM, Wang Dong wrote:
>> dasd_read just reads what the device got.
>> Previously, no matter what flag the disk got, if it has a file system,
>> the flag will never be read, although it got one. it is not good.
>> what we did is just reading what the disk got regardless of the
>> existence of file system.
> What?  Flags have nothing to do with what filesystem is present.
But the flag cannot be read with the presence of the filesystem previously.
That's why the change.
>> But when to set a flag on disk, if a file system exists, a warning will
>> raised. Because some flag does not work well along with file system, ex.
>> lvm/raid.
> Is there something goofy that dasd does with these flags?  For MBR and
> GPT, they just set the partition type code, and filesystems do not know
> or care about that, so why do you say that this can cause damage to your
> filesystem?
Nothing goofy. Just the property of the lvm/raid. Because when to
make a partition to lvm/raid, the filesystem will be ripped out.
It may make some sense to avoid the presence of filesystem along with flag.
But this is not an issue.

Then after our discussion, we try to add a warning when users try to set the
flag raid/lvm with the presence of filesystem.


-- 
Best regards. Wang Dong




More information about the parted-devel mailing list