[parted-devel] [PATCH] libparted/dasd: improve lvm/raid flag handling for DASD-CDL

[Phil Susi]

On 4/23/2017 10:11 PM, Wang Dong wrote:
>        ▷       ▷       if ((strncmp(PART_TYPE_RAID, str, 6) == 0) &&¶
>  451▷       ▷           (ped_file_system_probe(&part->geom) == NULL))¶
>  452▷       ▷       ▷       ped_partition_set_flag(part,
> PED_PARTITION_RAID, 1);¶
>  453▷       ▷ else¶
>  454▷       ▷       ▷       ped_partition_set_flag(part,
> PED_PARTITION_RAID, 0);¶
>  455¶
>  456▷       ▷       if ((strncmp(PART_TYPE_LVM, str, 6) == 0) &&¶
>  457▷       ▷           (ped_file_system_probe(&part->geom) == NULL))¶
>  458▷       ▷       ▷       ped_partition_set_flag(part,
> PED_PARTITION_LVM, 1);¶
>  459▷       ▷ else¶
>  460▷       ▷       ▷       ped_partition_set_flag(part,
> PED_PARTITION_LVM, 0);¶
> 
> Maybe I did not put it clearly. The flag is on the partition table. But
> it cannot be read with a filesystem existence.
> 
> 
> The code above is from libparted/labels/dasd.c, function dasd_read(),
> master branch.

Ahh, that code is wrong then; it should not be checking for a filesystem.