[parted-devel] [PATCH] libparted/dasd: improve lvm/raid flag handling for DASD-CDL

[Sebastian Parschauer]

Hi Brian,

if you're committing fixes right now, then please commit this one as
well. I've already acked it and it is part of SUSE parted. TIA

Cheers,
Sebastian

On 24.05.2017 14:54, Wang Dong wrote:
> This commit corrects the reading of lvm/raid flags on DASD/CDL formatted
> disks. Previously, users were not able to see what was the actual flags
> stored on the disk. Now the file system check is removed and this issue
> is corrected.
> 
> Signed-off-by: André Wild <wild at linux.vnet.ibm.com>
> Signed-off-by: Wang Dong <dongdwdw at linux.vnet.ibm.com>
> Signed-off-by: Hendrik Brueckner <brueckner at linux.vnet.ibm.com>
> ---
>  libparted/labels/dasd.c | 15 +++------------
>  1 file changed, 3 insertions(+), 12 deletions(-)
> 
> diff --git a/libparted/labels/dasd.c b/libparted/labels/dasd.c
> index ed0c82a..c57f20b 100644
> --- a/libparted/labels/dasd.c
> +++ b/libparted/labels/dasd.c
> @@ -446,18 +446,9 @@ dasd_read (PedDisk* disk)
>  		}
>  
>  		dasd_data = part->disk_specific;
> -
> -		if ((strncmp(PART_TYPE_RAID, str, 6) == 0) &&
> -		    (ped_file_system_probe(&part->geom) == NULL))
> -			ped_partition_set_flag(part, PED_PARTITION_RAID, 1);
> -		else
> -			ped_partition_set_flag(part, PED_PARTITION_RAID, 0);
> -
> -		if ((strncmp(PART_TYPE_LVM, str, 6) == 0) &&
> -		    (ped_file_system_probe(&part->geom) == NULL))
> -			ped_partition_set_flag(part, PED_PARTITION_LVM, 1);
> -		else
> -			ped_partition_set_flag(part, PED_PARTITION_LVM, 0);
> +		dasd_data->raid = !strncmp(PART_TYPE_RAID, str, 6);
> +		dasd_data->lvm = !strncmp(PART_TYPE_LVM, str, 6);
> +		dasd_partition_set_system(part, part->fs_type);
>  
>  		if (strncmp(PART_TYPE_SWAP, str, 6) == 0) {
>  			fs = ped_file_system_probe(&part->geom);
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/parted-devel/attachments/20171220/6e1dcb83/attachment.sig>