[parted-devel] About the obsolete use of struct initialization

[Brian C. Lane]

On Tue, Jan 31, 2017 at 02:01:38PM -0500, Phil Susi wrote:
> On 6/7/2016 2:09 PM, Brian C. Lane wrote:
> > On Tue, Jun 07, 2016 at 11:04:13AM +0800, Wang Dong wrote:
> >> Hi,
> >>
> >> I am going to write some code under libparted.
> >> But I found struct initialization which is an obsolete use.
> >>
> >> *for example*:
> >>          boo = {next: 1 , current: 2}
> >>
> >> Actually, I found this use in other places.
> >>
> >> I checked it out and it turns out this use is obsolete in gcc 2.5
> >> And I found my gcc is 5.x. So I think this use may be so old.
> >> Can I use the new? But I am not sure if the keeping use of this
> >> is for compatibility.
> >>
> >> *So I just ask should I use comply with**
> >> **the style of old or can I use the new initialization style?*
> > 
> > parted is a fairly old project :) I haven't seen any build errors
> > related to using the old style initialization so I'd stick with it.
> > parted is also used in a number of different environments, so I wouldn't
> > want to introduce changes that may break some of those.
> 
> I would think that in 2017, we should probably start using the C99
> standard ;)
> 

If we switch it should be a complete pass at it, with ample warning so
that we don't surprise anyone.

-- 
Brian C. Lane (PST8PDT)