[parted-devel] [PATCH] libparted/dasd: Fix printing flags 'raid' and 'lvm'

Phil Susi psusi at ubuntu.com
Mon May 22 15:46:00 UTC 2017


On 5/22/2017 11:22 AM, Sebastian Parschauer wrote:
> The flags 'raid' and 'lvm' are not printed for DASD CDL partitions
> but fdasd shows that they are set. In the function dasd_read(),
> the return value of ped_file_system_probe() is checked for NULL
> before setting the flags. This is wrong as we want a file system
> type to be set. So check for not NULL instead.

It looks to me like that check was refusing to set the raid or lvm flag
if a valid filesystem was detected ( normally there should not be one if
it is really lvm or raid ), and since you reversed that logic, it will
only set the flag if a filesystem *is* detected, which normally will not
be the case, so that should break these flags.




More information about the parted-devel mailing list