[parted-devel] [PATCH] libparted/dasd: Fix printing flags 'raid' and 'lvm'

Arvin Schnell aschnell at suse.com
Mon May 22 19:17:18 UTC 2017


On Mon, May 22, 2017 at 01:19:18PM -0400, Phil Susi wrote:
> On 5/22/2017 12:11 PM, Sebastian Parschauer wrote:
> > Thanks for the reply. I've checked with zeroing the DASD first and
> > you're right. But that check for NULL can still be a problem for a tool
> > using parted. I'll check with the YaST guys who requested a change here.
> 
> I would think that the check should be removed entirely.  While it is
> unusual to have a valid filesystem in a raid or lvm volume, [...]

This is not so unusual. E.g. with RAID level 1 and mdadm metadata
version 1.0 the RAID metadata is at the end of the underlying
devices while the beginning of the underlying devices match the
RAID device. So if you have a filesystem on the RAID device
parted will not show the RAID flag of the partition.

Thus I also suggest to remove the check entirely.

ciao Arvin

-- 
Arvin Schnell, <aschnell at suse.com>
Senior Software Engineer, Research & Development
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
Maxfeldstraße 5
90409 Nürnberg
Germany



More information about the parted-devel mailing list