[parted-devel] [PATCH] Add support for NVDIMM devices

Brian C. Lane bcl at redhat.com
Fri Nov 3 15:13:49 UTC 2017


On Fri, Nov 03, 2017 at 08:50:14AM -0400, Phil Susi wrote:
> On 11/1/2017 8:35 PM, Brian C. Lane wrote:
> > My understanding is that this is the only way to tell what these new
> > devices are, and we're already doing the same thing for nvme. It's
> > limited by a couple of things:
> > 
> >  1. Only blkext major's will be considered.
> >  2. It's at the end of the if/else so SCSI, etc. have already been
> >     checked.
> >  3. The filename path is canonicalized by ped_device_get before calling
> >     new() so internally we're always using the /dev/pmem name no matter
> >     what the symlink says.
> 
> What if someone mknods a differently named dev node rather than just
> using a symlink?  I would think there would be something in sysfs that
> identifies the type of device more accurately than the name of the devnode.

Worst case is that it falls back to saying 'Unknown'. The only real
effect of this patch is to make identifying the device a little nicer.

-- 
Brian C. Lane (PST8PDT)



More information about the parted-devel mailing list