[parted-devel] [PATCH] libparted/labels: link with libiconv if needed

[Brian C. Lane]

On Sun, Nov 05, 2017 at 11:33:37PM +0100, Arnout Vandecappelle (Essensium/Mind) wrote:
> gpt.c uses iconv so it should link with it. Otherwise, on platforms
> where libiconv is a separate library, we get a link failure of parted:
> 
>     CCLD     parted
>   ../libparted/.libs/libparted.so: undefined reference to `libiconv'
>   ../libparted/.libs/libparted.so: undefined reference to `libiconv_open'
>   ../libparted/.libs/libparted.so: undefined reference to `libiconv_close'
> 
> Since iconv functionality is needed unconditionally (not only when
> gettext is enabled), AM_ICONV needs to be added to configure.ac.
> ---

Looks good to me, thanks. Tested against Fedora 27.

-- 
Brian C. Lane (PST8PDT)