[parted-devel] [PATCH] libparted: Add support for MBR id and GPT GUID of UDF filesystem

[Pali Rohár]

On Thursday 16 August 2018 11:40:20 Phillip Susi wrote:
> On 8/13/2018 4:31 PM, Pali Rohár wrote:
> > Without registering a new libparted fs code it is not possible to assign
> > MBR id or GPT GUID. So there is a stub for udf filesystem.
> 
> It would be nice to be able to recognize udf in parted print too.  I
> don't suppose you could implement udf_probe?

UDF detection is not simple when you want to do it correctly. But later
I can implement it. What probe function needs to return? Just true/false
if device is a UDF filesystem? Or it needs to return also some metadata?

> Also could you add a NEWS entry and a test case?

NEW entry is there:

diff --git a/NEWS b/NEWS
index ee6efb6..0d0294e 100644
--- a/NEWS
+++ b/NEWS
@@ -47,6 +47,8 @@ GNU parted NEWS                                    -*- outline -*-
 
 ** New Features
 
+  Add support for MBR id and GPT GUID of UDF filesystem.
+
   libparted-fs-resize: Work on non 512 byte sectors.
 
   Add resizepart command to resize a partition.  This works even on

About test case, I looked into repository and I'm really not sure what
and how to write.

I just compiled and manually tested that when I create a new partition
of udf type it has correct MBR id.

-- 
Pali Rohár
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/parted-devel/attachments/20180819/0ce43f9e/attachment.sig>