[parted-devel] [PATCH] libparted: Add support for MBR id and GPT GUID of UDF filesystem

Pali Rohár pali.rohar at gmail.com
Tue Aug 28 12:50:53 BST 2018


On Monday 27 August 2018 12:31:25 Phillip Susi wrote:
> On 8/27/2018 12:05 PM, Pali Rohár wrote:
> > Sorry, but I do not understand you. I cannot remove special handling. As
> > I wrote for block sizes < 2048 it is needed, because VSD size != block
> > size.
> 
> Your third loop exists only to go back and check the other 3 anchor
> offsets that the first two loops don't check.  Just have the first two
> loops check all 4 anchor offsets, preferably by having detect_anchor
> drop it's rel_block argument and just put the 4 offsets in there.

That would change detection of block size and may improperly detect it!

But if we are not interested in block size, only in YES/NO answer, then
it should work.

-- 
Pali Rohár
pali.rohar at gmail.com



More information about the parted-devel mailing list