[parted-devel] [PATCH] libparted: Add support for MBR id and GPT GUID of UDF filesystem

Pali Rohár pali.rohar at gmail.com
Tue Aug 28 18:06:21 BST 2018


On Tuesday 28 August 2018 13:50:53 Pali Rohár wrote:
> On Monday 27 August 2018 12:31:25 Phillip Susi wrote:
> > On 8/27/2018 12:05 PM, Pali Rohár wrote:
> > > Sorry, but I do not understand you. I cannot remove special handling. As
> > > I wrote for block sizes < 2048 it is needed, because VSD size != block
> > > size.
> > 
> > Your third loop exists only to go back and check the other 3 anchor
> > offsets that the first two loops don't check.  Just have the first two
> > loops check all 4 anchor offsets, preferably by having detect_anchor
> > drop it's rel_block argument and just put the 4 offsets in there.
> 
> That would change detection of block size and may improperly detect it!
> 
> But if we are not interested in block size, only in YES/NO answer, then
> it should work.

In attachment is a new version, I tried to do what you suggested.

-- 
Pali Rohár
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: isudf.c
Type: text/x-csrc
Size: 4357 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/parted-devel/attachments/20180828/7fe8c7f0/attachment.c>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/parted-devel/attachments/20180828/7fe8c7f0/attachment.sig>


More information about the parted-devel mailing list