[parted-devel] [PATCH] linux: Include <sys/sysmacros.h> for major() macro.

Sebastian Parschauer sparschauer at suse.de
Wed May 2 15:40:03 BST 2018


On 04.04.2018 18:25, Brian C. Lane wrote:
> From: "Richard W.M. Jones" <rjones at redhat.com>
> 
> Since glibc 2.27 this header is required.
> ---
>  libparted/arch/linux.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c
> index 31b98ab..7e86b51 100644
> --- a/libparted/arch/linux.c
> +++ b/libparted/arch/linux.c
> @@ -41,6 +41,7 @@
>  #include <sys/utsname.h>        /* for uname() */
>  #include <scsi/scsi.h>
>  #include <assert.h>
> +#include <sys/sysmacros.h>
>  #ifdef ENABLE_DEVICE_MAPPER
>  #include <libdevmapper.h>
>  #endif
> 

A note that this has been committed the same day already would have been
nice. This inactive upstream parted rather appears to me to be Red Hat
parted if you don't give us a chance to discus your patches and if our
patches keep laying around without a comment or uncommitted.

I'm willing to help out commenting patches from others. In return I'd
prefer if others would do the same for me. This is frustrating. We
should all have the same goal to improve a common upstream parted and to
reduce the number of custom patches.

Cheers,
Sebastian



More information about the parted-devel mailing list