[parted-devel] [PATCH 1/2] gpt_read: reintroduce restoring the primary/backup GPT when corruption

[Brian C. Lane]

On Wed, Nov 07, 2018 at 07:11:05AM +0000, Hatayama, Daisuke wrote:
> Currently, no primary/backup GPT is restored when one of them is
> corrupted due to the commit 432a33115c50005bbe96a09d55edc7d034715ec8.
> 
> According to the description of the commit, the purpose of the commit
> is to deal with corruption of pMBR due to another issue during
> clobbering, but there seems no such issue because now
> ped_disk_clobber() avoids pMBR to clobber.

I am opposed to this change. I think the current behavior is safer, and
makes sense. Doing a print should not make changes to the disk, and when
one or the other header is corrupt (but not both) things still work
correctly.

The header *will* be fixed when you make an explicit change to the disk.

-- 
Brian C. Lane (PST8PDT)