[parted-devel] [PATCH 0/7] Fix GCC warnings

Shin'ichiro Kawasaki kawasaki at juno.dti.ne.jp
Wed Aug 14 02:59:16 BST 2019


Parted release 3.2.153 fixed all GCC warnings which stops the parted build
(Thx!). Still GCC reports warnings which do not stop the build. This patch
series suggests code changes to fix those warnings. With this, all warnings
in alpha release work branch (https://github.com/bcl/parted/pull/6) will be
fixed. (Still some warnings are left in the parted master branch.)

I don't think this patch series is urgent or required for 3.3 release.
As an exception, first two patches are rather straight forward and could
be picked up in 3.3 release. Other patches are worth slow review with care.

Shin'ichiro Kawasaki (7):
  libparted: Fix warnings from GCC's -Wimplicit-fallthrough
  libparted: Fix a GCC warning -Wunused-but-set-variable
  libparted: Fix warnings from GCC 8 -Wunused-variable and
    -Warray-bounds
  libparted: Fix warnings from GCC 8 -Wsuggest-attribute=const
  libparted: Fix warnings from GCC 8 -Wsuggest-attribute=pure
  libparted: Avoid warnings from GCC 8 -Wsuggest-attribute=pure
  libparted: Avoid a GCC warning for unused functions

 libparted/fs/amiga/affs.c       |  5 ++---
 libparted/fs/amiga/amiga.c      |  1 +
 libparted/fs/fat/bootsector.c   |  2 +-
 libparted/fs/r/fat/bootsector.c |  7 +++----
 libparted/fs/r/fat/bootsector.h |  2 --
 libparted/fs/r/fat/calc.c       | 24 +++++++++++++++---------
 libparted/fs/r/fat/clstdup.c    |  5 +++++
 libparted/fs/r/fat/context.c    |  4 ++--
 libparted/fs/r/fat/count.c      |  4 ++--
 libparted/fs/r/fat/table.c      |  9 +++++++--
 libparted/fs/r/fat/traverse.c   | 14 +++++++-------
 libparted/fs/r/hfs/advfs.c      |  4 ++--
 libparted/fs/r/hfs/advfs_plus.c |  4 ++--
 libparted/fs/r/hfs/cache.c      |  5 +++++
 libparted/fs/r/hfs/hfs.c        |  4 ++++
 libparted/fs/r/hfs/reloc.c      |  1 +
 16 files changed, 59 insertions(+), 36 deletions(-)

-- 
2.22.0




More information about the parted-devel mailing list