[parted-devel] [PATCH 04/24] libparted: Avoid a GCC warning for unused functions
Shin-ichiro KAWASAKI
kawasaki at juno.dti.ne.jp
Sat Nov 21 00:29:57 GMT 2020
On 2020-11-19 06:06, Brian C. Lane wrote:
> On Mon, Nov 16, 2020 at 03:30:38PM -0500, Phillip Susi wrote:
>>
>> Brian C. Lane writes:
>>
>>> To avoid the warning, add two more '#if 0' to disable the two functions.
>>
>> Rather than #if 0 out more code, why not just delete all of the unused
>> code?
>>
>
> I agree, with git there's no reason to leave these kinds of things in
> the codebase. Especially since it's named clobber :)
>
I agree also. I was just not sure if there would be any reason to leave those
'#if 0'. I saw Brian already removed them in the master-gcc10-warnings branch.
Thanks!
P.S. It's great to see no warning during parted build :)
--
Best Regards,
Shin'ichiro Kawasaki
More information about the parted-devel
mailing list