[parted-devel] [PATCH 2/6] amiga_read: need free part and partition when constraint_exact is NULL

Wu Guanghao wuguanghao3 at huawei.com
Wed Dec 15 08:30:00 GMT 2021


When constraint_exact is NULL and exit, need to release part and partition,
otherwise there will be memory leaks

Signed-off-by: Wu Guanghao <wuguanghao3 at huawei.com>
---
 libparted/labels/rdb.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/libparted/labels/rdb.c b/libparted/labels/rdb.c
index cbbf29a..8096285 100644
--- a/libparted/labels/rdb.c
+++ b/libparted/labels/rdb.c
@@ -545,8 +545,11 @@ amiga_read (PedDisk* disk)
 
 		PedConstraint *constraint_exact
 			= ped_constraint_exact (&part->geom);
-		if (constraint_exact == NULL)
+		if (constraint_exact == NULL) {
+			ped_partition_destroy(part);
+			free(partition);
 			return 0;
+		}
 		bool ok = ped_disk_add_partition (disk, part, constraint_exact);
 		ped_constraint_destroy (constraint_exact);
 		if (!ok) {
-- 
2.27.0




More information about the parted-devel mailing list