[parted-devel] [PATCH 0/2] Hacking our way to a release...

[Brian C. Lane]

It has been a frustrating 24 hours.

I tried to 'quickly' do a 3.4 release yesterday and immediately ran into
several roadblocks.

First was gnulib/lib/version-etc.c having 2020 as its copyright date.

So I tried to update gnulib. But that broke the build because they
dropped a '#define free rpl_free' into the pile of stuff that runs
before the build. I've sent a bugreport to gnulib about that, and cc'd
this list on it.

The gnulib update also pulls in a giant pile of new commits, so even if
it had passed I was going to end up doing another alpha and another week
to give people a chance to test.

So I patched version-etc.c with a new date, and started yet another
build... but we have checks to make sure non-public gnulib commits
aren't included. USUALLY these checks are a great idea. Gets frustrating
when trying to work around a problem that wasn't caused by the parted
codebase though.

I finally figured out how to disable the check (really, this build
system is worse than crawling through a cave with no flashlight, I'd
love to replace it with something easier to understand but I don't have
time...).

SO: Where I'm at right now is a non-public gnulib commit that *only*
changes the date from 2020 to 2021 in the gnulib/lib/version-etc.c file
and a commit to disable the non-public gnulib commit check.

The actual code gets copied into the ./lib/ directory in the tar, so
it's not like it only lives on my ssd. But it will break anyone trying
to run from git until I revert it. I don't see any way around that.

I'm as confident as I ever am that this is the best solution for now,
we're stuck until gnulib gets fixed. I'd rather release with the code in
the alpha anyway, and deal with large changes after 3.4

Any objections?

If not, I'll do a build of this tomorrow and we'll have a shiny new
parted 3.4 available :)

Thanks,

Brian

Brian C. Lane (2):
  Include local gnulib change to version-etc.c date
  cfg.mk: disable submodule checks to work around broken upstream gnulib

 cfg.mk | 4 ++++
 gnulib | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

-- 
2.26.2