From bcl at redhat.com Mon Jun 29 21:33:04 2026 From: bcl at redhat.com (Brian C. Lane) Date: Mon, 29 Jun 2026 13:33:04 -0700 Subject: [parted-devel] ExFAT support In-Reply-To: References: <36933605-b100-4bbd-8610-bad94486c888@plouf.fr.eu.org> Message-ID: On Sat, May 09, 2026 at 11:08:34PM +0200, Victor Couty wrote: > Here is the fixed version of the patch. Pascal was correct: t1700 formats > the entire device and msdos probe is executed first, returning a false > positive for an msdos label. My previous testing only included an actual > partition so i missed this case. I updated msdos_probe to add the check just > like FAT and NTFS. A full-disk ExFAT fs is now properly detected and all > tests are passing. ExFAT implementation ended up being very similar to NTFS. Thanks, I've tested this locally and pushed it to the master branch of parted. I'll add it to the rawhide version of parted on Fedora later today. Your patch was still malformed though, I had to clean it up a little -- it looks like thunderbird is deleting blank lines which make the diff unable to apply. Luckily it was short enough I could manually tweak it. In the future could you try using git send-email instead? Thanks, Brian -- Brian C. Lane (PST8PDT) - weldr.io - lorax - parted - pykickstart - osbuild From victor at couty.eu Mon Jun 29 22:19:18 2026 From: victor at couty.eu (Victor Couty) Date: Mon, 29 Jun 2026 23:19:18 +0200 Subject: [parted-devel] ExFAT support In-Reply-To: References: <36933605-b100-4bbd-8610-bad94486c888@plouf.fr.eu.org> Message-ID: <11e962c8-b323-4c63-a4f3-788ae50af66a@couty.eu> Thanks, Sorry about the patch being malformed again, i thought i had found the right options to prevent this. I will use git send-email in the future. Thank you for manually fixing the patch and merging it. Victor Couty Le 29/06/2026 ? 22:33, Brian C. Lane a ?crit?: > On Sat, May 09, 2026 at 11:08:34PM +0200, Victor Couty wrote: >> Here is the fixed version of the patch. Pascal was correct: t1700 formats >> the entire device and msdos probe is executed first, returning a false >> positive for an msdos label. My previous testing only included an actual >> partition so i missed this case. I updated msdos_probe to add the check just >> like FAT and NTFS. A full-disk ExFAT fs is now properly detected and all >> tests are passing. ExFAT implementation ended up being very similar to NTFS. > Thanks, I've tested this locally and pushed it to the master branch of > parted. I'll add it to the rawhide version of parted on Fedora later > today. > > Your patch was still malformed though, I had to clean it up a little -- > it looks like thunderbird is deleting blank lines which make the diff > unable to apply. Luckily it was short enough I could manually tweak it. > > In the future could you try using git send-email instead? > > Thanks, > > Brian >