[Parted-maintainers] [Feature request] Add SIZE listing to the print menu

Jari Aalto+mail.linux jari.aalto@cante.net
Fri, 04 Mar 2005 01:22:41 +0200


There is wishlist item from 2001 in Debian bug tracking system a request
for SIZE to be added to the displayed columns. This is _very_ good feature
which helps to calculate correct sizes (start, end). Please consider adding
following patch (or similar) to future parted releases.

Jari

P.s.

I've CC'd QA, because this situation is too common in Debian's package bug
listings. What's the purpose of QA if there are years old items that nobody
cares to submit forward or act upon on? Shame on you - parted maintainer
team:

    How closely do you work with your upstream software author?
    http://blog.andrew.net.au/2005/02/25#upstream

-----------------------------------------------------------------------
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=109613

Package: parted
Version: 1.4.17-1
Severity: wishlist
Tags: patch

Wouldn't it be nice if there is a 'Size' column on 'print' output?

Example:
(parted) p
Disk geometry for /dev/hda: 0.000-14324.625 megabytes
Disk label type: msdos
Minor    Start       End        Size    Type      Filesystem  Flags
1          0.031    298.081    298.050  primary   FAT         boot
2        298.081   8032.500   7734.418  extended              
5        298.112   3294.580   2996.468  logical   ntfs        
6       3294.611   4094.692    800.081  logical   ext2        
7       4094.723   6142.038   2047.315  logical   ext2        
8       6142.069   8032.500   1890.430  logical   ext2        
3       8032.500   8158.007    125.507  primary   linux-swap  
4       8158.008  14323.579   6165.571  primary   ext2        
(parted) 

here's the patch of parted/parted.c

------8<------
--- parted.c-origWed Aug 22 12:24:25 2001
+++ parted.cWed Aug 22 13:45:07 2001
@@ -717,7 +717,7 @@
 has_name = ped_disk_type_check_feature (disk->type,
         PED_DISK_TYPE_PARTITION_NAME);
 
-printf (_("Minor    Start       End     "));
+printf (_("Minor    Start       End        Size    "));
 if (has_extended)
 printf (_("Type      "));
 printf (_("Filesystem  "));
@@ -736,9 +736,11 @@
 
 printf ("%-5d ", part->num);
 
-printf ("%10.3f %10.3f  ",
+printf ("%10.3f %10.3f %10.3f  ",
 (int) part->geom.start * 1.0 / MEGABYTE_SECTORS,
-(int) part->geom.end * 1.0 / MEGABYTE_SECTORS);
+(int) part->geom.end * 1.0 / MEGABYTE_SECTORS,
+(int) (part->geom.end - part->geom.start)*1.0
+/ MEGABYTE_SECTORS);
 
 if (has_extended)
 printf ("%-9s ",
------8<------