[Parted-maintainers] Bug#413184: [vorlon@debian.org: Re: Bug#397973: parted: Fix mac partition table corruption]

[Steve Langasek]

Right, forwarding to the right bug, since the main bug moved out from under
me.

----- Forwarded message from Steve Langasek <vorlon at debian.org> -----

From: Steve Langasek <vorlon at debian.org>
To: David Härdeman <david at hardeman.nu>
Cc: 397973 at bugs.debian.org, 397973-submitter at bugs.debian.org
Subject: Re: Bug#397973: parted: Fix mac partition table corruption
Date: Sat, 3 Mar 2007 22:00:59 -0800

On Sat, Mar 03, 2007 at 03:25:20AM +0100, David Härdeman wrote:
> >So "clearing" the flag will only clear it in the internal mac_data
> >structure, it won't cause the system name of the partition to be reset?  Or
> >is this handled by mac_partition_set_system?

> Yes, the system name will not be reset. clearing the flag implies 
> nothing else than that it doesn't apply, it doesn't say what type the 
> partition is after the flag is removed.

Which means, AIUI, that clearing the flag is not sufficient to clear the
flag on disk, so if a user clears the flag, saves changes, closes parted (or
similar), and restarts parted, the flag will show up again, correct?

That seems suboptimal to me.

> If we would set a default, then a partition of type foobar (without the 
> lvm flag set) would get its system type changed if you executed "set 
> <partnr> lvm off" in parted.

Yes, I understand that's a deficiency of how raid flag support is
implemented on mac partition tables.

> Also, I believe this is the same approach that has been taken in the 
> later versions of the upstream package (see the source package in 
> experimental).

Ah well, it's a minor point anyway, compared with the bits that are wholly
breaking partman, so I won't insist on it (at least, not here and now).

Maintainers, please advise whether you're planning a maintainer upload of
parted to fix this for etch, otherwise I'll probably NMU this weekend.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon at debian.org                                   http://www.debian.org/

----- End forwarded message -----
----- Forwarded message from Steve Langasek <vorlon at debian.org> -----

From: Steve Langasek <vorlon at debian.org>
To: David Härdeman <david at hardeman.nu>
Cc: 397973 at bugs.debian.org, 397973-submitter at bugs.debian.org
Subject: Re: parted: Fix mac partition table corruption
Date: Sat, 3 Mar 2007 22:05:38 -0800

A further concern on this patch:

On Sat, Mar 03, 2007 at 02:47:04AM +0100, David Härdeman wrote:

> diff -ur ./parted-1.7.1.orig/libparted/labels/mac.c ./parted-1.7.1/libparted/labels/mac.c
> --- ./parted-1.7.1.orig/libparted/labels/mac.c	2006-05-25 19:28:55.000000000 +0200
> +++ ./parted-1.7.1/libparted/labels/mac.c	2007-03-03 02:41:42.000000000 +0100
> @@ -1260,19 +1260,23 @@
>  		return 1;
>  
>  	case PED_PARTITION_LVM:
> -		mac_data->is_lvm = state;
> -		if (state)
> +		if (state) {
>  			strcpy (mac_data->system_name, "Linux_LVM");
> -		else
> -			mac_partition_set_system (part, part->fs_type);
> +			mac_data->is_lvm = state;
> +		} else {
> +			if (mac_data->is_lvm)
> +				mac_partition_set_system (part, part->fs_type);
> +		}
>  		return 1;

So in this case, if (!state), mac_data->is_lvm is never un-set.  Is that not
an issue?

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon at debian.org                                   http://www.debian.org/

----- End forwarded message -----