[Parted-maintainers] Bug#579948: [parted-devel] Some debugging info

[Jim Meyering]

Colin Watson wrote:

> On Mon, Jun 14, 2010 at 08:40:12PM +0200, Karel Zak wrote:
>> On Mon, Jun 14, 2010 at 01:06:09PM +0100, Colin Watson wrote:
>> > parted-devel, can anyone comment on this?  It seems to me that either
>> > (a) _get_lax_constraint should be using ped_alignment_any for its start
>> > alignment, rather than aligning to sectors * heads boundaries, or (b)
>> > Sun labels really and truly require cylinder alignment, in which case
>> > requests to use optimal alignment shouldn't be honoured.
>>
>> The begin of the partition has to be defined in cylinders:
>>
>>         struct __attribute__ ((packed)) _SunRawPartition {
>>                 u_int32_t       start_cylinder; /* where the part starts... */
>>                 u_int32_t       num_sectors;    /* ...and it's length */
>>         };
>>
>> IMHO it does not make sense to use non-cylinder alignment here.
>
> In that case, I think that the sun part of
> 723ea23c5df68cbe67d1f518ef484f4c77f516fa should be reverted.  CCing Hans
> since that was his change.
>
>
> From: Colin Watson <cjwatson at ubuntu.com>
> Date: Tue, 15 Jun 2010 19:49:40 +0100
> Subject: [PATCH] sun: revert "implement disk flag operations"
>
> This reverts the libparted/labels/sun.c part of
> 723ea23c5df68cbe67d1f518ef484f4c77f516fa.  Sun disk labels do not appear
> to be able to handle non-cylinder alignment
> (http://bugs.debian.org/579948).

Thanks!  I've applied that.
However, since it would have made a test fail,
I first applied this change: