[Parted-maintainers] Bug#578097: [parted-devel] Debian Bug #578097: No support for CMS-formatted disks

[Jim Meyering]

Stephen Powell wrote:
...
> In the process of checking out the results, I discovered a bug in my code.
> In include/parted/vtoc.h, at or near line 105, as part of the structure
> declaration for ldl_volume_label, there is a line that says
>
>         char ldl_version;       /* Version number, valid for ldl format      */
>
> It should say
>
>         char ldl_version[1];    /* Version number, valid for ldl format      */
>
> I was clued into this by a bunch of compile warnings in libparted/labels/dasd.c
> complaining about conversion of integer to pointer without a cast,
> or something like that.

Hi Stephen,

Thanks for the fix.
Until today I had not compiled your changes on an s390x.
When I did, there were 3 other minor problems, addressed
by the patch below, just after the one you suggested.

That got past "make check" as a non-privileged user.
However, running "make check" as root exercises several
other cases that cannot be tested as a regular user, and
at least two of those are failing.  Those failures
are not due to your changes, so as soon as I have
a test or two to exercise your changes I'll feel
comfortable pushing the result.  I expect to use
the same mechanism as used in a few other tests
whereby you specify a device and its size like this:

    sudo make check DEVICE_TO_ERASE=/dev/sdd DEVICE_TO_ERASE_SIZE=999MB

But it won't be this weekend, so maybe next week...