[Parted-maintainers] Bug#578097: [parted-devel] Debian Bug #578097: No support for CMS-formatted disks

Jim Meyering jim at meyering.net
Sat Oct 23 08:59:31 UTC 2010


Stephen Powell wrote:
> As promised earlier today, I now have the following patch files on my
> web site ready for download:
>
> http://www.wowway.com/~zlinuxman/parted/vtoc.h.diff   (apply to include/parted/vtoc.h)
> http://www.wowway.com/~zlinuxman/parted/dasd.c.diff   (apply to libparted/labels/dasd.c)
> http://www.wowway.com/~zlinuxman/parted/fdasd.c.diff  (apply to libparted/labels/fdasd.c)
> http://www.wowway.com/~zlinuxman/parted/vtoc.c.diff   (apply to libparted/labels/vtoc.c)
>
> I have not made any updates to NEWS.  You can edit that as you see
> fit.  These are ordinary "context diffs", with three lines of context.
> I don't understand this "git" stuff.  I've never used it.  Sorry.
> My starting point was the Debian source package for parted, version 2.2-5.
...

Thanks for your patience, Stephen.
I've applied your patches locally, made some tiny changes
and included the result below.
(I moved 2 decls "down", and made indentation more consistent)

Two things remain to be done:

  - add a sentence or two for NEWS; the idea is to be as brief as possible
      while still giving enough of the details so people don't have to
      go look at the commit logs or -- gasp! -- the code.

  - a recipe or two (the more the merrier) for tests that fail
      without your patch, but pass with it.
      For a change of this size and complexity, I would be remiss
      not to include at least one or two patches.  It's ok (expected
      even) that the tests will run only on an s390 and will be skipped
      on other systems.

I've lightly modified words from your email to make the log
message below.  If you'd like something different there, let me know.

I haven't tested these changes at all, but should be able
to do so next week.

Jim



More information about the Parted-maintainers mailing list