Bug#549726: reassign to perl

[Niko Tyni]

On Mon, Oct 05, 2009 at 06:40:43PM -0400, Noah Meyerhans wrote:
> reassign 549726 perl
> thanks
> 
> Hi perl folks.  Somewhere between perl 5.10.0-25 and 5.10.1-5, something
> in perl broke the spamassassin packaging.  

Hm. I tried to rebuild all packages whose names matched /perl/ with
5.10.1, but spamassassin isn't one of them. Sorry for missing it,
advance warning would have been good.

> It seems related to the
> ExtUtils::MakeMaker changes, but it's different from what went on in
> #545904.  It seems that perl is trying to put spamassassin's files in /,
> rather than in a subdir of debian, but passing
> DESTDIR=`pwd`/debian/spamassassin to "make install" doesn't seem to
> change things at all.

The Makefile.PL in spamassassin is trying to be clever about DESTDIR support:

 # MakeMaker prior to 6.11 doesn't support DESTDIR which is needed for
 # packaging with builddir!=destdir. See bug 2388.
 $mm_knows_destdir    = $ExtUtils::MakeMaker::Recognized_Att_Keys{DESTDIR};
 $mm_has_good_destdir = $mm_version >= 6.11;
 # Add DESTDIR hack only if it's requested (and necessary)
 $mm_needs_destdir    = $opt{'destdir'} && !$mm_has_good_destdir;
 $mm_has_destdir      = $mm_knows_destdir || $mm_needs_destdir;
 push(@ATT_KEYS, 'DESTDIR') if $mm_needs_destdir;
 
Now, %ExtUtils::MakeMaker::Recognized_Att_Keys was made a lexical variable
instead of a global one in 6.43_01, right after the version bundled with
Perl 5.10.0. See

 http://search.cpan.org/diff?from=ExtUtils-MakeMaker-6.42&to=ExtUtils-MakeMaker-6.43_01&w=1#lib/ExtUtils/MakeMaker.pm

Hardcoding $mm_knows_destdir = 1 makes the package build for me.

I can't see any indication that %Recognized_Att_Keys is part of
the ExtUtils::MakeMaker public API, so I think the bug here is that
spamassassin was using EU::MM private parts and not that the private
parts changed.

I'm not into BTS ping pong, so please reassign back yourself if you agree.
-- 
Niko Tyni   ntyni at debian.org