Bug#628522: perl: ExtUtils::MakeMaker overriding CCFLAGS when passed to WriteMakefile

[Niko Tyni]

On Thu, Jun 02, 2011 at 06:23:25PM +0100, Dominic Hargreaves wrote:
> On Mon, May 30, 2011 at 11:05:43PM +0300, Niko Tyni wrote:

> > The attached naive patch appends CCFLAGS to $Config{ccflags}. Could you
> > please try and see if it fixes things for you? Ideally, it would also
> > be useful to see if it breaks anything that used to work without it.
> > (The patch is with -p1 from the EU::MM repository so it won't apply to the
> > perl sources with just 'git am').
> 
> I applied this patch to a test build of perl 5.14.0 and rebuilt the
> XS modules in sid with it.

> All the packages that failed because of this before now built okay

> and I couldn't spot any new breakage that can be attributed to this
> change.

> > Once that's confirmed, I think the issue needs to be discussed upstream
> > before applying this for the Debian packages.
> 
> Okay; would you be able to do this now that we have validated the patch
> as working?

Sure, will file a ticket in the CPAN EU:MM queue next.

I expect that you didn't build libdbd-oracle-perl (it's in contrib
as it needs some Oracle binaries), but if you still have the build
logs available, could you please check if any other log contains
$Config{ccflags} twice? 

Such packages would be currently using CCFLAGS "correctly" and potentially
be affected negatively by the fix. I doubt that having the flags twice
breaks anything, but verifying that would be good.

Grepping for -D_REENTRANT.*-D_REENTRANT or something like that should do.
-- 
Niko Tyni   ntyni at debian.org