Bug#914013: perl: missing-depends-on-sensible-utils

[Dominic Hargreaves]

On Sun, Nov 18, 2018 at 04:05:43PM +0200, Niko Tyni wrote:
> Package: perl
> Version: 5.28.0-3
> 
> As prompted by lintian:
> 
> E: libperl-dev: missing-depends-on-sensible-utils usr/lib/x86_64-linux-gnu/libperl.a
> E: perl-modules-5.28: missing-depends-on-sensible-utils usr/share/perl/5.28.0/Pod/Perldoc/ToTerm.pm
> E: libperl5.28: missing-depends-on-sensible-utils usr/lib/x86_64-linux-gnu/libperl.so.5.28.0
> E: libperl5.28: missing-depends-on-sensible-utils usr/lib/x86_64-linux-gnu/perl/5.28.0/CORE/patchlevel-debian.h
> E: libperl5.28: missing-depends-on-sensible-utils usr/lib/x86_64-linux-gnu/perl/5.28.0/Config_heavy.pl
> E: perl-base: missing-depends-on-sensible-utils usr/bin/perl
> E: perl-base: missing-depends-on-sensible-utils usr/bin/perl5.28.0
> E: perl-base: missing-depends-on-sensible-utils usr/lib/x86_64-linux-gnu/perl-base/Config_heavy.pl
> E: perl-debug: missing-depends-on-sensible-utils usr/bin/debugperl
> 
> This is a result of us building with -Dpager=/usr/bin/sensible-pager,
> which ends up in the binary files, and patching Pod::Perldoc::ToTerm
> to treat sensible-pager like 'less'. (The lintian check simply looks
> for relevant strings in the binary packages, skipping /usr/share/doc
> and /usr/share/locale.)
> 
> It looks to me like
> 
> - patchlevel-debian.h, libperl.{a,so} and the statically linked binaries
>   only have sensible-pager in a patch description, so false positives
> 
> - the Pod::Perldoc::ToTerm changes in debian/perldoc-pager.diff don't
>   imply any kind of dependency on sensible-pager, so a false positive
> 
> The only relevant hit is Config_heavy.pl. The implied dependency (perl
> default pager) should IMO be at most a recommendation, though I'd lean
> on the side of a suggestion.
> 
> So I propose we fix this by adding Suggests: sensible-utils in perl-base
> and libperl5.28, and overriding the rest.
> 
> Thoughts?

Sounds good to me!