[Piuparts-commits] rev 444 - in piatti/home/piupartsm/bin: . known_problems

Holger Levsen holger at alioth.debian.org
Sat Jun 20 12:52:04 UTC 2009


Author: holger
Date: 2009-06-20 12:52:03 +0000 (Sat, 20 Jun 2009)
New Revision: 444

Modified:
   piatti/home/piupartsm/bin/detect_well_known_errors
   piatti/home/piupartsm/bin/known_problems/command_not_found_error.conf
   piatti/home/piupartsm/bin/known_problems/command_not_found_issue.conf
   piatti/home/piupartsm/bin/known_problems/files_in_usr_local_error.conf
   piatti/home/piupartsm/bin/known_problems/overwrite_other_packages_files_error.conf
   piatti/home/piupartsm/bin/known_problems/owned_files_after_purge_error.conf
   piatti/home/piupartsm/bin/known_problems/owned_files_by_many_packages_error.conf
   piatti/home/piupartsm/bin/known_problems/processes_running_error.conf
   piatti/home/piupartsm/bin/known_problems/unowned_files_after_purge_error.conf
Log:
nicer html, uglier code

Modified: piatti/home/piupartsm/bin/detect_well_known_errors
===================================================================
--- piatti/home/piupartsm/bin/detect_well_known_errors	2009-06-20 12:11:58 UTC (rev 443)
+++ piatti/home/piupartsm/bin/detect_well_known_errors	2009-06-20 12:52:03 UTC (rev 444)
@@ -46,7 +46,11 @@
 		echo "$COMMAND" > $LOGS
 		if [ -s $LOGS ] ; then 
 			OUTPUT=$HTDOCS/$SECTION/${problem%.conf}.tpl
-			echo "<p>$HELPTEXT</p>" > $OUTPUT
+			echo '<table class="righttable"><tr class="titlerow"><td class="titlecell">' > $OUTPUT
+			echo "$HEADER" >> $OUTPUT
+			echo '</td></tr><tr class="normalrow"><td class="contentcell2">' >> $OUTPUT
+			echo "$HELPTEXT" >> $OUTPUT
+			echo '</td></tr><tr class="titlerow"><td class="alerttitlecell">Please file bugs!</td></tr></tr><tr class="normalrow"><td class="contentcell2" colspan="3">' >> $OUTPUT
 			COUNT=$(cut -d "_" -f1 $LOGS|sort -u|wc -l)
 			echo "<p>Affected packages in $SECTION: $COUNT</p>" >> $OUTPUT
 			echo "<ul>" >> $OUTPUT
@@ -54,7 +58,7 @@
 				echo "<li><a href='/$LOG'>$LOG</a></li>" >> $OUTPUT
 			done
 			echo "$LOGS" >> ${KNOWNLOGS[$NR]}
-			echo "</ul>" >> $OUTPUT
+			echo "</ul></td></tr></table>" >> $OUTPUT
 		else
 			touch ${KNOWNLOGS[$NR]}
 		fi
@@ -78,15 +82,18 @@
 	done
 	if [ -s $LOGS ] ; then
 		OUTPUT=$HTDOCS/$SECTION/unknown_failures.tpl
-		echo "<h2>Packages with failures not yet well known detected</h2>"
+		echo '<table class="righttable"><tr class="titlerow"><td class="titlecell">' > $OUTPUT
+		echo "Packages with failures not yet well known detected" >> $OUTPUT
+		echo '</td></tr><tr class="normalrow"><td class="contentcell2">' >> $OUTPUT
 		echo "<p>Please investigate and improve detection of known error types!</p>" >> $OUTPUT
+		echo '</td></tr><tr class="titlerow"><td class="alerttitlecell">Please file bugs!</td></tr></tr><tr class="normalrow"><td class="contentcell2" colspan="3">' >> $OUTPUT
 		COUNT=$(cut -d "_" -f1 $LOGS|sort -u|wc -l)
 		echo "<p>Affected packages in $SECTION: $COUNT</p>" >> $OUTPUT
 		echo "<ul>" >> $OUTPUT
 		for LOG in $(cat $LOGS) ; do
 			echo "<li><a href='/$LOG'>$LOG</a></li>" >> $OUTPUT
 		done
-		echo "</ul>" >> $OUTPUT
+		echo "</ul></td></tr></table>" >> $OUTPUT
 	fi
 	rm $LOGS ${KNOWNLOGS[$NR]} $UNKNOWNLOGS
 	let "NR += 1"

Modified: piatti/home/piupartsm/bin/known_problems/command_not_found_error.conf
===================================================================
--- piatti/home/piupartsm/bin/known_problems/command_not_found_error.conf	2009-06-20 12:11:58 UTC (rev 443)
+++ piatti/home/piupartsm/bin/known_problems/command_not_found_error.conf	2009-06-20 12:52:03 UTC (rev 444)
@@ -3,19 +3,17 @@
 #
 COMMAND=`rgrep "command not found" fail|cut -d " " -f1|sed -e "s#log:#log#"|sort -u 2>/dev/null`
 ISSUE=0
-HELPTEXT="
-<h2>Packages with failed logs with the string 'command not found'
-</h2>
-
+HEADER='Packages with failed logs with the string "command not found"'
+HELPTEXT='
 <p>
 WARNING: it has not been verified that this error really caused the package to
 fail the piuparts test.
-<br>In fact, there are also successful logs with 'command not found' in them.
+<br>In fact, there are also successful logs with "command not found" in them.
 </p>
 
 <p>
 From the third paragraph about the meaning of the depends field in
-<a href='http://www.debian.org/doc/debian-policy/ch-relationships.html#s-binarydeps'>http://www.debian.org/doc/debian-policy/ch-relationships.html#s-binarydeps</a>
+<a href="http://www.debian.org/doc/debian-policy/ch-relationships.html#s-binarydeps">http://www.debian.org/doc/debian-policy/ch-relationships.html#s-binarydeps</a>
 </p>
 
 <pre>
@@ -24,8 +22,4 @@
 postrm cannot rely on any non-essential packages to be present during the
 purge phase__.
 </pre>
-
-<p>
-Please file bugs!
-</p>
-"
+'

Modified: piatti/home/piupartsm/bin/known_problems/command_not_found_issue.conf
===================================================================
--- piatti/home/piupartsm/bin/known_problems/command_not_found_issue.conf	2009-06-20 12:11:58 UTC (rev 443)
+++ piatti/home/piupartsm/bin/known_problems/command_not_found_issue.conf	2009-06-20 12:52:03 UTC (rev 444)
@@ -3,12 +3,13 @@
 #
 COMMAND=`rgrep "command not found" pass|grep -v "/var/lib/dpkg/info/openssh-client.postrm: line 34: delgroup: command not found" |cut -d " " -f1|sed -e "s#log:#log#"|sort -u 2>/dev/null`
 ISSUE=1
-HELPTEXT="
-<h2>Packages which passed the piuparts test but have logs with the string 'command not found'</h2>
-
+HEADER='Packages which passed the piuparts test but have logs with the string "command not found"'
+HELPTEXT='
 <p>Failures due to #530501 (/var/lib/dpkg/info/openssh-client.postrm: line 34: delgroup: command not found) have been ignored.</p>
 
-<p>From the third paragraph about the meaning of the depends field in http://www.debian.org/doc/debian-policy/ch-relationships.html#s-binarydeps</p>
+<p>From the third paragraph about the meaning of the depends field in 
+<a href="http://www.debian.org/doc/debian-policy/ch-relationships.html#s-binarydeps">http://www.debian.org/doc/debian-policy/ch-relationships.html#s-binarydeps</a>:
+</p>
 
 <pre>
 The Depends field should also be used if the postinst, prerm or postrm scripts
@@ -16,8 +17,4 @@
 postrm cannot rely on any non-essential packages to be present during the
 purge phase__.
 </pre>
-
-<p>
-Please file bugs!
-</p>
-"
+'

Modified: piatti/home/piupartsm/bin/known_problems/files_in_usr_local_error.conf
===================================================================
--- piatti/home/piupartsm/bin/known_problems/files_in_usr_local_error.conf	2009-06-20 12:11:58 UTC (rev 443)
+++ piatti/home/piupartsm/bin/known_problems/files_in_usr_local_error.conf	2009-06-20 12:52:03 UTC (rev 444)
@@ -3,16 +3,10 @@
 #
 COMMAND=`rgrep "not owned" fail|grep usr/local/|cut -d " " -f1|sed -e "s#log:#log#"|sort -u 2>/dev/null`
 ISSUE=0
-HELPTEXT="
-<h2>
-Packages with files and/or directories in /usr/local/ after purge
-</h2>
-
+HEADER='Packages with files and/or directories in /usr/local/ after purge'
+HELPTEXT='
 <p>
 This is a violation of policy 9.1.2: see 
-<a href='http://www.debian.org/doc/debian-policy/ch-opersys.html#s9.1.2'>http://www.debian.org/doc/debian-policy/ch-opersys.html#s9.1.2</a>
-
-<p>
-Please file bugs!
+<a href="http://www.debian.org/doc/debian-policy/ch-opersys.html#s9.1.2">http://www.debian.org/doc/debian-policy/ch-opersys.html#s9.1.2</a>.
 </p>
-"
+'

Modified: piatti/home/piupartsm/bin/known_problems/overwrite_other_packages_files_error.conf
===================================================================
--- piatti/home/piupartsm/bin/known_problems/overwrite_other_packages_files_error.conf	2009-06-20 12:11:58 UTC (rev 443)
+++ piatti/home/piupartsm/bin/known_problems/overwrite_other_packages_files_error.conf	2009-06-20 12:52:03 UTC (rev 444)
@@ -3,19 +3,12 @@
 #
 COMMAND=`rgrep -E "trying to overwrite (.*) which is also in package" fail|cut -d " " -f1|sed -e "s#log:#log#"|sort -u 2>/dev/null`
 ISSUE=0
-HELPTEXT="
-<h2>
-Packages with failed logs because they tried to overwrite other packages files
-</h2>
-
+HEADER='Packages with failed logs because they tried to overwrite other packages files'
+HELPTEXT='
 <p>
 This is because the package tries to overwrite another packages files without declaring a conflict or replaces relation. See policy 7.4 and 7.6 at 
-<a href='http://www.debian.org/doc/debian-policy/ch-relationships.html#s-conflicts'>http://www.debian.org/doc/debian-policy/ch-relationships.html#s-conflicts</a>
+<a href="http://www.debian.org/doc/debian-policy/ch-relationships.html#s-conflicts">http://www.debian.org/doc/debian-policy/ch-relationships.html#s-conflicts</a>
 and 
-<a href='http://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces'>http://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces</a>
+<a href="http://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces">http://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces</a>
 </p>
-
-<p>
-Please file bugs!
-</p>
-"
+'

Modified: piatti/home/piupartsm/bin/known_problems/owned_files_after_purge_error.conf
===================================================================
--- piatti/home/piupartsm/bin/known_problems/owned_files_after_purge_error.conf	2009-06-20 12:11:58 UTC (rev 443)
+++ piatti/home/piupartsm/bin/known_problems/owned_files_after_purge_error.conf	2009-06-20 12:52:03 UTC (rev 444)
@@ -3,21 +3,14 @@
 #
 COMMAND=`rgrep "owned by:" fail|grep -v ","|grep -v usr/local/|cut -d " " -f1|sed -e "s#log:#log#"|sort -u 2>/dev/null`
 ISSUE=0
-HELPTEXT="
-<h2>
-Packages with owned files after purge
-</h2>
-
+HEADER='Packages with owned files after purge'
+HELPTEXT='
 <p>
 WARNING: this list might contain false positives.
 </p>
 
 <p>
 Packages need to remove owned files after purge, see 
-<a href='http://www.debian.org/doc/debian-policy/ch-files.html#s10.7.3'>http://www.debian.org/doc/debian-policy/ch-files.html#s10.7.3</a>
+<a href="http://www.debian.org/doc/debian-policy/ch-files.html#s10.7.3">http://www.debian.org/doc/debian-policy/ch-files.html#s10.7.3</a>
 </p>
-
-<p>
-Please file bugs!
-</p>
-"
+'

Modified: piatti/home/piupartsm/bin/known_problems/owned_files_by_many_packages_error.conf
===================================================================
--- piatti/home/piupartsm/bin/known_problems/owned_files_by_many_packages_error.conf	2009-06-20 12:11:58 UTC (rev 443)
+++ piatti/home/piupartsm/bin/known_problems/owned_files_by_many_packages_error.conf	2009-06-20 12:52:03 UTC (rev 444)
@@ -3,16 +3,9 @@
 #
 COMMAND=`rgrep "owned by" fail|grep "," |cut -d " " -f1|sed -e "s#log:#log#"|sort -u 2>/dev/null`
 ISSUE=0
-HELPTEXT="
-<h2>
-Packages with failed logs which have conffiles owned by two or more packages which are not removed by dpkg correctly
-</h2>
-
+HEADER='Packages with failed logs which have conffiles owned by two or more packages which are not removed by dpkg correctly'
+HELPTEXT='
 <p>
 So these might be ok packages (or not, as there might be other problems), but we cannot know until dpkg is fixed.
 </p>
-
-<p>
-Please file this important bug against dpkg!
-</p>
-"
+'

Modified: piatti/home/piupartsm/bin/known_problems/processes_running_error.conf
===================================================================
--- piatti/home/piupartsm/bin/known_problems/processes_running_error.conf	2009-06-20 12:11:58 UTC (rev 443)
+++ piatti/home/piupartsm/bin/known_problems/processes_running_error.conf	2009-06-20 12:52:03 UTC (rev 444)
@@ -3,18 +3,11 @@
 #
 COMMAND=`rgrep "ERROR: FAIL: Processes are running inside chroot" fail|cut -d " " -f1|sed -e "s#log:#log#"|sort -u 2>/dev/null`
 ISSUE=0
-HELPTEXT="
-<h2>
-Packages with failed logs because of processes left behind
-</h2>
-
+HEADER='Packages with failed logs because of processes left behind'
+HELPTEXT='
 <p>
 There were processes running inside the chroot at the end of the piuparts run.
 This is probably due to directly calling /etc/rc.d/ scripts in packages maintainer scripts, which is a violation of policy 9.3.3.2 and must be replaced by using policy-rc.d - see 
-<a href='http://www.debian.org/doc/debian-policy/ch-opersys.html#s9.3.3'>http://www.debian.org/doc/debian-policy/ch-opersys.html#s9.3.3</a>.
+<a href="http://www.debian.org/doc/debian-policy/ch-opersys.html#s9.3.3">http://www.debian.org/doc/debian-policy/ch-opersys.html#s9.3.3</a>.
 </p>
-
-<p>
-Please file bugs!
-</p>
-"
+'

Modified: piatti/home/piupartsm/bin/known_problems/unowned_files_after_purge_error.conf
===================================================================
--- piatti/home/piupartsm/bin/known_problems/unowned_files_after_purge_error.conf	2009-06-20 12:11:58 UTC (rev 443)
+++ piatti/home/piupartsm/bin/known_problems/unowned_files_after_purge_error.conf	2009-06-20 12:52:03 UTC (rev 444)
@@ -3,10 +3,8 @@
 #
 COMMAND=`rgrep "not owned" fail|grep -v "/usr/share/mime/"|grep -v usr/local/|cut -d " " -f1|sed -e "s#log:#log#"|sort -u 2>/dev/null`
 ISSUE=0
-HELPTEXT="
-<h2>Packages with unowned files after purge
-</h2>
-
+HEADER='Packages with unowned files after purge'
+HELPTEXT='
 <p>
 WARNING: this list might contain false positives. One group of them are packages with files in /usr/share/mime - those are bugs from shared-mime-info (#527063) and have been ignored for this list.
 There are probably others like this as well.
@@ -14,9 +12,6 @@
 
 <p>
 Packages with unowned files after purge (violating policy 6.8) see 
-<a href='http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails'>http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails</a>
+<a href="http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails">http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails</a>
 </p>
-
-<p>
-Please file bugs!
-</p>"
+'




More information about the Piuparts-commits mailing list